Re: [PATCH] xfrm: Reset secpath in xfrm failure

From: Myungho Jung
Date: Wed Mar 06 2019 - 16:18:27 EST


On Wed, Mar 06, 2019 at 12:35:43PM +0100, Steffen Klassert wrote:
> On Wed, Mar 06, 2019 at 04:33:08PM +0900, Myungho Jung wrote:
> > In esp4_gro_receive() and esp6_gro_receive(), secpath can be allocated
> > without adding xfrm state to xvec. Then, sp->xvec[sp->len - 1] would
> > fail and result in dereferencing invalid pointer in esp4_gso_segment()
> > and esp6_gso_segment(). Reset secpath if xfrm function returns error.
> >
> > Reported-by: syzbot+b69368fd933c6c592f4c@xxxxxxxxxxxxxxxxxxxxxxxxx
> > Signed-off-by: Myungho Jung <mhjungk@xxxxxxxxx>
>
> The patch itself looks ok, but please add a 'Fixes' tag to
> the commit message.
>
> Thanks!

Hi Steffen,

Thanks for reviewing the change. I'll add fixes tag and resubmit it.

Thanks,
Myungho