Re: [PATCH 12/13] regulator: wm831x isink: Fix notifier mutex lock warning

From: Charles Keepax
Date: Wed Mar 06 2019 - 04:28:18 EST


On Tue, Feb 26, 2019 at 03:51:28PM +0000, Steve Twiss wrote:
> The mutex for the regulator_dev must be controlled by the caller of
> the regulator_notifier_call_chain(), as described in the comment
> for that function.
>
> Failure to mutex lock and unlock surrounding the notifier call results
> in a kernel WARN_ON_ONCE() which will dump a backtrace for the
> regulator_notifier_call_chain() when that function call is first made.
> The mutex can be controlled using the regulator_lock/unlock() API.
>
> Fixes: d4d6b722e780 ("regulator: Add WM831x ISINK support")
> Suggested-by: Adam Thomson <Adam.Thomson.Opensource@xxxxxxxxxxx>
> Signed-off-by: Steve Twiss <stwiss.opensource@xxxxxxxxxxx>
> ---

Acked-by: Charles Keepax <ckeepax@xxxxxxxxxxxxxxxxxxxxx>

Thanks,
Charles