Re: [RFC PATCH] fs: Make splice() and tee() take into account O_NONBLOCK flag on pipes

From: Linus Torvalds
Date: Mon Mar 04 2019 - 19:09:46 EST


On Mon, Mar 4, 2019 at 4:04 PM Linus Torvalds
<torvalds@xxxxxxxxxxxxxxxxxxxx> wrote:
>
> Of course, if it turns out that this breaks something that assumes
> that splice blocks purely based on the SPLICE_F_NONBLOCK flag, we'll
> have to revert it. Looking at the history of splice, it does look like
> it has always ignored O_NONBLOCK.

Note that the "arguably buggy" argument is not an actual real argument
in the presence of regressions. It's more a "I wish reality wasn't
that way" argument, but it doesn't actually _change_ reality.

Of course, in the case of sendfile() (which is where that comment is),
I don't think we ever really even tested it either way.

Linus