Re: [PATCH] net: dsa: mv88e6xxx: fix unused function warning

From: Heiner Kallweit
Date: Mon Mar 04 2019 - 15:42:42 EST


On 04.03.2019 21:36, Arnd Bergmann wrote:
> The newly introduced function is only used inside of an #ifdef
> and causes a warning when that is disabled:
>
> drivers/net/dsa/mv88e6xxx/chip.c:4623:13: error: unused function 'mv88e6xxx_ports_cmode_init' [-Werror,-Wunused-function]
>
> Move it into the same #ifdef block to shut up the warning.
>
> Fixes: ed8fe20205ac ("net: dsa: mv88e6xxx: prevent interrupt storm caused by mv88e6390x_port_set_cmode")
> Signed-off-by: Arnd Bergmann <arnd@xxxxxxxx>
> ---
A fix has been submitted already. See discussion here:
https://marc.info/?t=155170356600004&r=1&w=2
and the fix here:
https://patchwork.ozlabs.org/patch/1051275/

Heiner