Re: [PATCH v3 06/34] csky: mm: Add p?d_large() definitions

[Kirill A. Shutemov]

On Wed, Feb 27, 2019 at 05:05:40PM +0000, Steven Price wrote:
> walk_page_range() is going to be allowed to walk page tables other than
> those of user space. For this it needs to know when it has reached a
> 'leaf' entry in the page tables. This information is provided by the
> p?d_large() functions/macros.
> 
> For csky, we don't support large pages, so add a stub returning 0.
> 
> CC: Guo Ren <guoren@xxxxxxxxxx>
> Signed-off-by: Steven Price <steven.price@xxxxxxx>
> ---
>  arch/csky/include/asm/pgtable.h | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/arch/csky/include/asm/pgtable.h b/arch/csky/include/asm/pgtable.h
> index edfcbb25fd9f..4ffdb6bfbede 100644
> --- a/arch/csky/include/asm/pgtable.h
> +++ b/arch/csky/include/asm/pgtable.h
> @@ -158,6 +158,8 @@ static inline int pmd_present(pmd_t pmd)
>  	return (pmd_val(pmd) != __pa(invalid_pte_table));
>  }
>  
> +#define pmd_large(pmd)	(0)

Nit: here and in other places, parentheses around 0 is not needed.

-- 
 Kirill A. Shutemov