Re: [PATCH v2] mfd: cros_ec: instantiate properly CrOS ISH MCU device

From: Andy Shevchenko
Date: Fri Mar 01 2019 - 02:28:20 EST


On Fri, Mar 01, 2019 at 09:36:11AM +0530, Rushikesh S Kadam wrote:
> Integrated Sensor Hub (ISH) is also a MCU running EC
> having feature bit EC_FEATURE_ISH. Instantiate it as
> a special CrOS EC device with device name 'cros_ish'.

> v2
> - Addressed review comments to term the CrOS EC device as a generic
> Integrated Sensor Hub.

> + /* The MCU is an Intel Integrated Sensor Hub */

This has to be adjusted as well. Intel ISH is just one of the example of ISHs.

> + EC_FEATURE_ISH = 40,

--
With Best Regards,
Andy Shevchenko