Re: [PATCH] cros_ec: instantiate properly Intel ISH MCU device

[Gwendal Grignou]

On Thu, Feb 28, 2019 at 4:18 AM Enric Balletbo Serra
<eballetbo@xxxxxxxxx> wrote:
>
> Hi Andy,
> Missatge de Andy Shevchenko <andriy.shevchenko@xxxxxxxxx> del dia dj.,
> 28 de febr. 2019 a les 8:57:
> >
> > On Thu, Feb 28, 2019 at 12:05:35AM +0100, Enric Balletbo Serra wrote:
> > > Missatge de Gwendal Grignou <gwendal@xxxxxxxxxxxx> del dia dc., 27 de
> > > febr. 2019 a les 19:37:
> > > > On Wed, Feb 27, 2019 at 10:08 AM Enric Balletbo i Serra
> > > > <enric.balletbo@xxxxxxxxxxxxx> wrote:
> > > > > On 27/2/19 16:13, Jett Rink wrote:
> >
> > > > You're right, the cros_ names are based on what the EC provides.
> > > > cros_ec for generic EC, fp, tp for fingerprint, touch pad
> > > > respectively.
> > > > ish is for standalone sensor hub [it does not have to be Intel Sensor Hub].
> > > >
> > >
> > > Thanks for the explanation. I didn't know that and I assumed the 'i'
> > > was for 'intel', maybe would be good call cros_ssh or cros_sh to avoid
> > > confusion?
> >
> > i is for Integrated. There is no confusion.
>
> Ok, thanks for the clarification. Now that is clear to me I'll send
> some reviews of this patch in a minute.
Regarding cros_scp, it may coexist with cros_ec or be standalone. It
is not clear yet.

Gwendal.
>
> Best regards,
> Enric
>
> > It seems you misread what was written in [] above.
> >
> > --
> > With Best Regards,
> > Andy Shevchenko
> >
> >