Re: [PATCH] doc: rcu: Suspicious RCU usage is a warning

From: Paul E. McKenney
Date: Thu Feb 28 2019 - 11:51:55 EST


On Thu, Feb 28, 2019 at 11:59:32AM +0100, Geert Uytterhoeven wrote:
> Suspicious RCU usage messages are reported as warnings.
>
> Fixes: a5dd63efda3d07b5 ("lockdep: Use "WARNING" tag on lockdep splats")
> Signed-off-by: Geert Uytterhoeven <geert+renesas@xxxxxxxxx>

Reviewed-by: Paul E. McKenney <paulmck@xxxxxxxxxxxxx>

> ---
> And before that, they were printed as errors, which was also never
> reflected in the documentation...
> ---
> Documentation/RCU/lockdep-splat.txt | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/Documentation/RCU/lockdep-splat.txt b/Documentation/RCU/lockdep-splat.txt
> index 9423b633526d14df..9c015976b174123f 100644
> --- a/Documentation/RCU/lockdep-splat.txt
> +++ b/Documentation/RCU/lockdep-splat.txt
> @@ -14,9 +14,9 @@ being the real world and all that.
> So let's look at an example RCU lockdep splat from 3.0-rc5, one that
> has long since been fixed:
>
> -===============================
> -[ INFO: suspicious RCU usage. ]
> --------------------------------
> +=============================
> +WARNING: suspicious RCU usage
> +-----------------------------
> block/cfq-iosched.c:2776 suspicious rcu_dereference_protected() usage!
>
> other info that might help us debug this:
> --
> 2.17.1
>