Re: [PATCH 0/8] net: ethernet: reduce calls to memset(,0)

From: Christoph Hellwig
Date: Thu Feb 28 2019 - 09:25:17 EST


On Tue, Feb 26, 2019 at 10:04:54PM -0800, Robert Eshleman wrote:
> This patch series removes calls to memset(,0) that are
> redundant when used in conjunction with a zalloc call or
> by simple zero-assignment of structs.

NAK. pci_zalloc_consistent is just as deprecated as
pci_alloc_consistent, and if you look at the implementation you'll
see that we actual zero the memory for both of them.

If you want to do some DMA-related busy work please just bulk convert
drivers from the PCI DMA API to the proper generic DMA API. Bonus
points for automatÑng that using a cocchinelle script.