Re: [PATCH v7 1/7] ARM: trusted_foundations: Support L2 cache maintenance

[Dmitry Osipenko]

28.02.2019 16:27, Russell King - ARM Linux admin ÐÐÑÐÑ:
> On Thu, Feb 28, 2019 at 04:17:01PM +0300, Dmitry Osipenko wrote:
>> +#ifdef CONFIG_CACHE_L2X0
>> +static void tf_cache_write_sec(unsigned long val, unsigned int reg)
>> +{
>> +	u32 l2x0_way_mask = 0xff;
>> +
>> +	switch (reg) {
>> +	case L2X0_CTRL:
>> +		if (l2x0_saved_regs.aux_ctrl & BIT(16))
> 
> And bit 16 is what?  We have definitions in one of the headers you've
> added above, please use them.  Thanks.
> 

Good catch, I missed that there is a definition for that bit. I'll make a v8 soon'ish, please let me know if there is anything else to be addressed. Yours r-b and a-b will be appreciated.