Re: [Drbd-dev] [PATCH] block: Mark expected switch fall-throughs

From: Gustavo A. R. Silva
Date: Tue Feb 26 2019 - 14:31:28 EST




On 1/29/19 3:42 AM, Roland Kammerer wrote:
> On Wed, Jan 23, 2019 at 12:45:01AM -0600, Gustavo A. R. Silva wrote:
>> In preparation to enabling -Wimplicit-fallthrough, mark switch cases
>> where we are expecting to fall through.
>>
>> Warning level 3 was used: -Wimplicit-fallthrough=3
>>
>> This patch is part of the ongoing efforts to enabling
>> -Wimplicit-fallthrough
>>
>> Signed-off-by: Gustavo A. R. Silva <gustavo@xxxxxxxxxxxxxx>
>> ---
>> drivers/block/drbd/drbd_int.h | 2 +-
>> drivers/block/drbd/drbd_receiver.c | 4 ++--
>> drivers/block/drbd/drbd_req.c | 2 +-
>> drivers/block/rsxx/core.c | 1 +
>> 4 files changed, 5 insertions(+), 4 deletions(-)
>>
>
> Hi Gustavo,
>
> as also discussed with Lars in person, obviously OK for the DRBD part.
>
> Acked-by: Roland Kammerer <roland.kammerer@xxxxxxxxxx>
>

Thank you, Roland.

Friendly ping:

Who can take this, please?

Thanks
--
Gustavo