Re: [PATCH v1 1/3] perf diff: Support --time filter option

[Jin, Yao]

On 2/25/2019 10:19 PM, Jiri Olsa wrote:
> On Mon, Feb 25, 2019 at 10:12:08PM +0800, Jin, Yao wrote:
> > On 2/25/2019 9:38 PM, Jiri Olsa wrote:
> > > On Mon, Feb 25, 2019 at 09:42:42PM +0800, Jin Yao wrote:
> > >
> > > SNIP
> > >
> > > >    COMPARISON
> > > >    ----------
> > > >    The comparison is governed by the baseline file. The baseline perf.data
> > > > diff --git a/tools/perf/builtin-diff.c b/tools/perf/builtin-diff.c
> > > > index 751e197..ddc41e7 100644
> > > > --- a/tools/perf/builtin-diff.c
> > > > +++ b/tools/perf/builtin-diff.c
> > > > @@ -19,12 +19,21 @@
> > > >    #include "util/util.h"
> > > >    #include "util/data.h"
> > > >    #include "util/config.h"
> > > > +#include "util/time-utils.h"
> > > >    #include <errno.h>
> > > >    #include <inttypes.h>
> > > >    #include <stdlib.h>
> > > >    #include <math.h>
> > > > +struct perf_diff {
> > > > +	struct perf_tool	tool;
> > > > +	const char		*time_str;
> > > > +	struct perf_time_interval *ptime_range;
> > > > +	int			range_size;
> > > > +	int			range_num;
> > >
> > > please align the members
> >
> > Not aligned? Sorry, could you give me an example?
>
> one extra tab before the name:
>
> 	struct perf_tool		 tool;
> 	const char			*time_str;
> 	struct perf_time_interval	*ptime_range;
> 	int				 range_size;
> 	int				 range_num;
>
> jirka

Oh, I see, thanks so much!

Thanks
Jin Yao