Re: [PATCH] ARM: dts: rockchip: add chosen node on veyron chromebooks

[Alexandru M Stan]

On Fri, Feb 15, 2019 at 3:09 PM Heiko StÃbner <heiko@xxxxxxxxx> wrote:
>
> Hi Enric,
>
> Am Freitag, 15. Februar 2019, 12:51:50 CET schrieb Enric Balletbo i Serra:
> > In order to use earlycon, the stdout-path property needs to be set
> > in the chosen node.
> >
> > Signed-off-by: Enric Balletbo i Serra <enric.balletbo@xxxxxxxxxxxxx>
>
> What's the reason for adding this only for the Chromebook variants?
> Uart2 is pretty much the standard output for all devices, so I'd assume
> at least all veyron boards should use uart2 as well, making this ideally
> live in the rk3288-veyron.dtsi instead?

Yep, all veyriants use uart 2, even when they're not chromebooks.
Feel free to put it in the other file instead.

Otherwise it'll make things like the Asus Chromebit (mickey), AOpen
Chromebox mini (fievel), and AOpen Chromebase (tiger) unhappy
while debugging.

The rk3288-veyron-chromebook.dtsi file is more for things that make
a chromebook portable. Ex: built in display, lid switch, cros-ec.

Note how we have no uart2 references either in our tree in the
chromebook specific dtsi:
https://chromium.googlesource.com/chromiumos/third_party/kernel/+/chromeos-3.14/arch/arm/boot/dts/rk3288-veyron-chromebook.dtsi

Alexandru Stan (amstan)