Re: [patch V5 4/8] nvme-pci: Simplify interrupt allocation

From: Thomas Gleixner
Date: Fri Feb 15 2019 - 04:54:43 EST


On Fri, 15 Feb 2019, Thomas Gleixner wrote:
> On Fri, 15 Feb 2019, Marc Zyngier wrote:
> > > + */
> > > + if (nrirqs == 1)
> > > + nr_read_queues = 0;
> > > + else if (write_queues >= nrirqs)
> > > + nr_read_queues = nrirqs - 1;
> >
> > ... while this seem to ensure that we carve out one write queue out of
> > the irq set. It looks like a departure from the original code, which
> > would set nr_read_queues to 1 in that particular case.
>
> Bah. right you are.

That needs to be:

nr_read_queues = 1;

obviously.

/me blushes.