Re: [PATCH 11/11] s390: don't redefined the HAS_IOMEM symbol

From: Masahiro Yamada
Date: Fri Feb 15 2019 - 02:45:12 EST


On Thu, Feb 14, 2019 at 2:40 AM Christoph Hellwig <hch@xxxxxx> wrote:
>
> Rely on the common defintion instead.
>
> Signed-off-by: Christoph Hellwig <hch@xxxxxx>
> ---
> arch/s390/Kconfig | 4 +---
> 1 file changed, 1 insertion(+), 3 deletions(-)
>
> diff --git a/arch/s390/Kconfig b/arch/s390/Kconfig
> index 9a25e19364f5..0f62e33ffcb2 100644
> --- a/arch/s390/Kconfig
> +++ b/arch/s390/Kconfig
> @@ -159,6 +159,7 @@ config S390
> select MODULES_USE_ELF_RELA
> select NEED_DMA_MAP_STATE if PCI
> select NEED_SG_DMA_LENGTH if PCI
> + select NO_IOMEM if !PCI


This does not work because NO_IOMEM is defined
in arch/um/Kconfig.


If you want to do this,
you must move NO_IOMEM to lib/Kconfig.



> select OLD_SIGACTION
> select OLD_SIGSUSPEND3
> select PCI_DOMAINS if PCI
> @@ -708,9 +709,6 @@ config PCI_NR_FUNCTIONS
>
> endif # PCI
>
> -config HAS_IOMEM
> - def_bool PCI
> -
> config CHSC_SCH
> def_tristate m
> prompt "Support for CHSC subchannels"
> --
> 2.20.1
>
>
> _______________________________________________
> linux-riscv mailing list
> linux-riscv@xxxxxxxxxxxxxxxxxxx
> http://lists.infradead.org/mailman/listinfo/linux-riscv



--
Best Regards
Masahiro Yamada