Re: [RFC 5/5] arm64: dts: imx8mq: Add the opp table and the cpu-supply nodes

[Lucas Stach]

Am Donnerstag, den 14.02.2019, 17:18 +0000 schrieb Abel Vesa:
> On 19-02-14 16:50:28, Lucas Stach wrote:
> > Hi Abel
> > 
> > Am Mittwoch, den 13.02.2019, 19:05 +0000 schrieb Abel Vesa:
> > > Add the opp table containing only non over drive opps.
> > > Also add the cpu-supply nodes for the A53 cores in the EVK board.
> > > 
> > > Signed-off-by: Abel Vesa <abel.vesa@xxxxxxx>
> > > ---
> > > Âarch/arm64/boot/dts/freescale/imx8mq-evk.dts | 17
> > > +++++++++++++++++
> > > Âarch/arm64/boot/dts/freescale/imx8mq.dtsiÂÂÂÂ| 23
> > > +++++++++++++++++++++++
> > > Â2 files changed, 40 insertions(+)
> > > 
> > > diff --git a/arch/arm64/boot/dts/freescale/imx8mq-evk.dts
> > > b/arch/arm64/boot/dts/freescale/imx8mq-evk.dts
> > > index 54737bf..114359e 100644
> > > --- a/arch/arm64/boot/dts/freescale/imx8mq-evk.dts
> > > +++ b/arch/arm64/boot/dts/freescale/imx8mq-evk.dts
> > > @@ -31,6 +31,23 @@
> > > Â		gpio = <&gpio2 19 GPIO_ACTIVE_HIGH>;
> > > Â		enable-active-high;
> > > Â	};
> > > +
> > > +};
> > > +
> > > +&A53_0 {
> > > +	cpu-supply = <&sw1a_reg>;
> > > +};
> > > +
> > > +&A53_1 {
> > > +	cpu-supply = <&sw1a_reg>;
> > > +};
> > > +
> > > +&A53_2 {
> > > +	cpu-supply = <&sw1a_reg>;
> > > +};
> > > +
> > > +&A53_3 {
> > > +	cpu-supply = <&sw1a_reg>;
> > > Â};
> > 
> > This should be a separate patch.
> > 
> 
> OK, will send as separate patches in the next version.
> 
> > And AFAICS this is wrong, sw1a on the MX8M-EVK is the GPU supply,
> > the
> > CPU is supplied by a dedicated switcher that is controlled via a
> > GPIO.
> > 
> 
> Hmm, I think you're right. At least this is what the following
> document says.
> 
> https://www.mouser.com/ds/2/302/IMX8MDQLQEVKHUG-1280333.pdf
> 
> So I guess this means there will not be any cpu-supply properties.Â

There is a variable voltage CPU supply, but you need to model it as a
gpio-regulator in the DT, it's not part of the PMIC provided rails.

Regards,
Lucas