Re: [PATCH v5 07/11] power: supply: max77650: add support for battery charger

[Pavel Machek]

Hi!

> +#define MAX77650_CHG_OFF			0x00
> +#define MAX77650_CHG_PREQ			0x01
> +
> +#define MAX77650_CHGIN_UNDERVOLTAGE_LOCKOUT	0x00
> +#define MAX77650_CHGIN_OVERVOLTAGE_LOCKOUT	0x01
> +#define MAX77650_CHGIN_OKAY			0x11

Thanks for doing this.

> +#define MAX77650_CHG_ON_CURR			0x02
> +#define MAX77650_CHG_ON_CURR_JEITA		0x03
> +#define MAX77650_CHG_ON_VOLT			0x04
> +#define MAX77650_CHG_ON_VOLT_JEITA		0x05
> +#define MAX77650_CHG_ON_TOPOFF			0x06
> +#define MAX77650_CHG_ON_TOPOFF_JEITA		0x07
> +#define MAX77650_CHG_DONE			0x08
> +#define MAX77650_CHG_DONE_JEITA			0x09
> +#define MAX77650_CHG_SUSP_PREQ_TIM_FAULT	0x0a
> +#define MAX77650_CHG_SUSP_FAST_CHG_TIM_FAULT	0x0b
> +#define MAX77650_CHG_SUSP_BATT_TEMP_FAULT	0x0c
> +
> +#define MAX77650_CHARGER_CHGIN_DTLS_MASK	GENMASK(3, 2)
> +#define MAX77650_CHARGER_CHGIN_DTLS_BITS(_reg) \
> +		(((_reg) & MAX77650_CHARGER_CHGIN_DTLS_MASK) >> 2)

But I guess these could use similar treatment?
							Pavel
							
-- 
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html

Attachment: signature.asc
Description: Digital signature