Re: [PATCH 1/2] asm-generic/io: Pass result on inX() accessor to __io_par()

From: Arnd Bergmann
Date: Wed Feb 13 2019 - 15:59:50 EST


On Wed, Feb 13, 2019 at 6:46 PM Will Deacon <will.deacon@xxxxxxx> wrote:

> On Tue, Feb 12, 2019 at 12:55:17PM +0100, Arnd Bergmann wrote:
>
> > For all I can see, this should not conflict with the usage of the
> > same macros on RISC-V, though it does make add a significant
> > difference, so I'd like to see an Ack from the RISC-V folks as
> > well (added to Cc), or possibly a change to arch/riscv/include/asm/io.h
> > to do a corresponding change.
>
> There's already a comment in that header which says that the accesses are
> ordered wrt timer reads, so I don't think anything needs to change there.
> For consistency with the macro arguments, I could augment their __io_par to
> take the read value as an unused argument, if that's what you mean?

Yes, that's what I meant, I should have been clearer there.

Arnd