Re: [PATCH v14 06/15] tracing: Add hist trigger snapshot() action

From: Tom Zanussi
Date: Wed Feb 13 2019 - 14:47:23 EST


Hi Steve,

On Wed, 2019-02-13 at 14:35 -0500, Steven Rostedt wrote:
> On Wed, 13 Feb 2019 14:25:51 -0500
> Steven Rostedt <rostedt@xxxxxxxxxxx> wrote:
> >
> > I noticed this because we hardcode the size in memcpy. Should hard
> > code
> > it above, otherwise it looks like elt_data->comm may be something
> > other
> > than TASK_COMM_LEN.
>
>
> Hi Tom,
>
> My comments on patch 5 and 6 are the only comments I have on the
> series. Could you address them and post a v15, and I'll pull them in
> and start testing them?
>

Great, yeah I'll make all those changes and post a v15 shortly.

Thanks,

Tom

> Thanks!
>
> -- Steve