Re: [PATCH 1/4] mm: Move recent_rotated pages calculation to shrink_inactive_list()

From: Daniel Jordan
Date: Wed Feb 13 2019 - 12:33:17 EST


On Tue, Feb 12, 2019 at 06:14:00PM +0300, Kirill Tkhai wrote:
> Currently, struct reclaim_stat::nr_activate is a local variable,
> used only in shrink_page_list(). This patch introduces another
> local variable pgactivate to use instead of it, and reuses
> nr_activate to account number of active pages.
>
> Note, that we need nr_activate to be an array, since type of page
> may change during shrink_page_list() (see ClearPageSwapBacked()).
>
> Signed-off-by: Kirill Tkhai <ktkhai@xxxxxxxxxxxxx>
> ---
> include/linux/vmstat.h | 2 +-
> mm/vmscan.c | 15 +++++++--------

include/trace/events/vmscan.h needs to account for the array-ification of
nr_activate too.