Re: [PATCH 2/5] tpm: Change calc_tpm2_event_size signature

[Jarkko Sakkinen]

On Mon, Feb 11, 2019 at 03:30:49PM +0100, bsz@xxxxxxxxxxxx wrote:
> From: Bartosz Szczepanek <bsz@xxxxxxxxxxxx>
> 
> Pass tcg_efi_specid_event as an argument instead of tcg_pcr_event, as the
> former is what is actually needed to compute event size. tcg_pcr_event
> structure describes TPM event log header (even though its name), from where
> efispecid can be extracted -- it seems cleaner and less misleading to do it
> out of calc_tpm2_event_size function.
> 
> Also, use ssize_t instead of int for event log size.
> 
> Signed-off-by: Bartosz Szczepanek <bsz@xxxxxxxxxxxx>

Unreviewable without call sites. NAK.

/Jarkko