Re: [PATCH] scsi: sd: fix entropy gathering for most rotational disks

From: Xuewei Zhang
Date: Tue Feb 12 2019 - 15:00:34 EST


Thanks for the fix James!

On Tue, Feb 12, 2019 at 8:59 AM Martin K. Petersen
<martin.petersen@xxxxxxxxxx> wrote:
>
>
> Jens,
>
> >> The fix is to set the non-rotational and add-randomness flags
> >> unconditionally early on in the disk initialization path, so they can
> >> be reset only if the device actually reports being non-rotational via
> >> the VPD page.
> >
> > Reviewed-by: Jens Axboe <axboe@xxxxxxxxx>

Reviewed-by: Xuewei Zhang <xueweiz@xxxxxxxxxx>

>
> Yeah, this looks good to me. I'll queue it up for fixes.
>
> --
> Martin K. Petersen Oracle Linux Engineering