Re: [PATCH v7 05/28] x86/asm/entry: annotate THUNKs

From: Jiri Slaby
Date: Tue Feb 12 2019 - 06:38:17 EST


On 12. 02. 19, 12:05, Borislav Petkov wrote:
> On Tue, Feb 12, 2019 at 11:27:19AM +0100, Jiri Slaby wrote:
>> Yes, they do not end up in the symbol table. But the macros make clear
>> where is the start of the function and especially where is the end
>> (something like closing bracket '}' in C). If you prefer not annotating
>> local symbols, I can of course drop it from everywhere. But to me it
>> looks more readable to see "here it starts" and "here it ends", still
>> without generating anything to the symbol table.
>
> Agreed. Boundary annotation makes sense.

OK, so I will switch all the *LOCAL* to .L prefix (perhaps as a separate
patch prior the series/post the series)?

thanks,
--
js
suse labs