Re: [PATCH V3 1/2] cpufreq: Allow light-weight tear down and bring up of CPUs

[Rafael J. Wysocki]

On Tue, Feb 12, 2019 at 11:47 AM Viresh Kumar <viresh.kumar@xxxxxxxxxx> wrote:
>

[cut]

> @@ -2488,7 +2505,8 @@ int cpufreq_register_driver(struct cpufreq_driver *driver_data)
>                     driver_data->target) ||
>              (driver_data->setpolicy && (driver_data->target_index ||
>                     driver_data->target)) ||
> -            (!!driver_data->get_intermediate != !!driver_data->target_intermediate))
> +            (!!driver_data->get_intermediate != !!driver_data->target_intermediate) ||
> +            (!driver_data->online ^ !driver_data->offline))

Why do you need the ^ here?  != should be sufficient:

!driver_data->online != !driver_data->offline

?

>                 return -EINVAL;
>
>         pr_debug("trying to register driver %s\n", driver_data->name);