Re: [PATCH 4.9 034/137] ARM: mmp/mmp2: dt: enable the clock

From: Pavel Machek
Date: Mon Feb 11 2019 - 15:51:32 EST


Hi!

> 4.9-stable review patch. If anyone has any objections, please let me know.
>
> ------------------
>
> [ Upstream commit f36797ee43802b367e59f0f9a9805304a4ff0c98 ]
>
> The device-tree booted MMP2 needs to enable the timer clock, otherwise
> it would stop ticking when the boot finishes.
>
> It can also use the clock rate from the clk, the non-DT boards need to
> keep using the hardcoded rates.
>
> Signed-off-by: Lubomir Rintel <lkundrak@xxxxx>
> Acked-by: Pavel Machek <pavel@xxxxxx>
> Signed-off-by: Olof Johansson <olof@xxxxxxxxx>
> Signed-off-by: Sasha Levin <sashal@xxxxxxxxxx>

While I agree this is good idea for mainline (thus my ack), I don't
think it is suitable for stable, as older kernels will not run on OLPC
in useful way, anyway.

Not-acked-for-stable-by: Pavel Machek <pavel@xxxxxx>

So I don't think this and ARM: dts: mmp2: fix TWSI2 is good idea for
stable kernels.

Pavel

--
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html

Attachment: signature.asc
Description: Digital signature