Re: [PATCH] kvm: fix kvm_ioctl_create_device() reference counting (CVE-2019-6974)

[Sasha Levin]

Hi,

[This is an automated email]

This commit has been processed because it contains a "Fixes:" tag,
fixing commit: 852b6d57dc7f kvm: add device control API.

The bot has tested the following trees: v4.20.7, v4.19.20, v4.14.98, v4.9.155, v4.4.173, v3.18.134.

v4.20.7: Build OK!
v4.19.20: Build OK!
v4.14.98: Build OK!
v4.9.155: Build OK!
v4.4.173: Failed to apply! Possible dependencies:
    023e9fddc361 ("KVM: PPC: Move xics_debugfs_init out of create")
    0919e84c0fc1 ("KVM: arm/arm64: vgic-new: Add IRQ sync/flush framework")
    140b086dd197 ("KVM: arm/arm64: vgic-new: Add GICv2 world switch backend")
    2b0cda878965 ("KVM: arm/arm64: vgic-new: Add CTLR, TYPER and IIDR handlers")
    4493b1c4866a ("KVM: arm/arm64: vgic-new: Add MMIO handling framework")
    59529f69f504 ("KVM: arm/arm64: vgic-new: Add GICv3 world switch backend")
    5e6431da8f3a ("KVM: arm/arm64: vgic-new: vgic_init: implement vgic_create")
    64a959d66e47 ("KVM: arm/arm64: vgic-new: Add acccessor to new struct vgic_irq instance")
    81eeb95ddbab ("KVM: arm/arm64: vgic-new: Implement virtual IRQ injection")
    90eee56c5f90 ("KVM: arm/arm64: vgic-new: Implement kvm_vgic_vcpu_pending_irq")
    a28ebea2adc4 ("KVM: Protect device ops->create and list_add with kvm->lock")
    b18b57787f5e ("KVM: arm/arm64: vgic-new: Add data structure definitions")
    c7da6fa43cb1 ("arm/arm64: KVM: Detect vGIC presence at runtime")
    c86c772191d7 ("KVM: arm/arm64: vgic-new: vgic_kvm_device: KVM device ops registration")
    e2c1f9abff83 ("KVM: arm/arm64: vgic-new: vgic_kvm_device: implement kvm_vgic_addr")
    ed9b8cefa916 ("KVM: arm/arm64: vgic-new: Add GICv3 MMIO handling framework")
    fb848db39661 ("KVM: arm/arm64: vgic-new: Add GICv2 MMIO handling framework")
    fca256026bb0 ("KVM: arm/arm64: vgic-new: vgic_kvm_device: KVM_DEV_ARM_VGIC_GRP_NR_IRQS")
    fd59ed3be17e ("KVM: arm/arm64: vgic-new: Add GICv3 CTLR, IIDR, TYPER handlers")

v3.18.134: Failed to apply! Possible dependencies:
    023e9fddc361 ("KVM: PPC: Move xics_debugfs_init out of create")
    05bc8aafe664 ("arm/arm64: KVM: wrap 64 bit MMIO accesses with two 32 bit ones")
    174178fed338 ("KVM: arm/arm64: add irqfd support")
    1d916229e348 ("arm/arm64: KVM: split GICv2 specific emulation code from vgic.c")
    3caa2d8c3b2d ("arm/arm64: KVM: make the maximum number of vCPUs a per-VM value")
    59892136c40d ("arm/arm64: KVM: pass down user space provided GIC type into vGIC code")
    662d9715840a ("arm/arm64: KVM: Kill CONFIG_KVM_ARM_{VGIC,TIMER}")
    832158125d2e ("arm/arm64: KVM: add vgic.h header file")
    83fe27ea5311 ("rcu: Make SRCU optional by using CONFIG_SRCU")
    96415257a1bd ("arm/arm64: KVM: refactor vgic_handle_mmio() function")
    a28ebea2adc4 ("KVM: Protect device ops->create and list_add with kvm->lock")
    b26e5fdac43c ("arm/arm64: KVM: introduce per-VM ops")
    c7da6fa43cb1 ("arm/arm64: KVM: Detect vGIC presence at runtime")
    d44758c0dfc5 ("KVM: arm/arm64: enable KVM_CAP_IOEVENTFD")
    d97f683d0f4b ("arm/arm64: KVM: refactor MMIO accessors")


How should we proceed with this patch?

--
Thanks,
Sasha