Re: [PATCH v3 1/2] media: uapi: Add H264 low-level decoder API compound controls.

From: Ezequiel Garcia
Date: Mon Feb 11 2019 - 12:12:44 EST


On Mon, 2019-02-11 at 15:39 +0100, Maxime Ripard wrote:
>
> diff --git a/include/uapi/linux/videodev2.h b/include/uapi/linux/videodev2.h
> index d6eed479c3a6..6fc955926bdb 100644
> --- a/include/uapi/linux/videodev2.h
> +++ b/include/uapi/linux/videodev2.h
> @@ -645,6 +645,7 @@ struct v4l2_pix_format {
> #define V4L2_PIX_FMT_H264 v4l2_fourcc('H', '2', '6', '4') /* H264 with start codes */
> #define V4L2_PIX_FMT_H264_NO_SC v4l2_fourcc('A', 'V', 'C', '1') /* H264 without start codes */
> #define V4L2_PIX_FMT_H264_MVC v4l2_fourcc('M', '2', '6', '4') /* H264 MVC */
> +#define V4L2_PIX_FMT_H264_SLICE v4l2_fourcc('S', '2', '6', '4') /* H264 parsed slices */

Nicolas and I have discussed the pixel format, and came up with
the following proposal.

Given this format represents H264 parsed slices, without any start code,
perhpaps we name it as:

V4L2_PIX_FMT_H264_SLICE_RAW

Then, we'd also add:

V4L2_PIX_FMT_H264_SLICE_ANNEX_B

To represent H264 parsed slices with annex B (3- or 4-byte) start code.
This one is what the Rockchip VPU driver would expose.

Ideas?