Re: [PATCH v6 9/9] vsprintf: Avoid confusion between invalid address and value

From: Andy Shevchenko
Date: Fri Feb 08 2019 - 12:27:24 EST


On Fri, Feb 08, 2019 at 04:23:10PM +0100, Petr Mladek wrote:
> We are able to detect invalid values handled by %p[iI] printk specifier.
> The current error message is "invalid address". It might cause confusion
> against "(efault)" reported by the generic valid_pointer_address() check.
>
> Let's unify the style and use the more appropriate error code description
> "(einval)".

The proper one should be "invalid address family". The proposed change
increases confusion.

--
With Best Regards,
Andy Shevchenko