Re: [EXT] Re: [PATCH v2] mtd: spi-nor: Fix wrong abbreviation HWCPAS

From: Tudor.Ambarus
Date: Fri Feb 08 2019 - 10:51:25 EST


Hi, Bean,

On 02/08/2019 05:27 PM, Bean Huo (beanhuo) wrote:
> Hi, Tutor
>
>> $ ./scripts/checkpatch.pl --strict
>> v2-mtd-spi-nor-Fix-wrong-abbreviation-HWCPAS.patch
>> WARNING: Missing Signed-off-by: line by nominal patch author 'Bean Huo
>> (beanhuo) <beanhuo@xxxxxxxxxx>'
>>
> I think, this is because of our email system, it always adds '(xxx)' between user name
> and email address.
> If you are convenient, please help fix since it is not such hug change.

I'm on a funny email server too, it keeps overwriting my email header "from
field". I have a workaround that might work for you too. Here's part of my
.gitconfig:

[user]
name = Tudor Ambarus
email = tudor.ambarus@xxxxxxxxxxxxx
[sendemail]
from = Tudor X Ambarus <tudor.ambarus@xxxxxxxxxxxxx>

Because my [sendemail] from field is different than my [user] name and email,
git send-email will add in the body of the patch the [user] name and email:

From: Tudor Ambarus <tudor.ambarus@xxxxxxxxxxxxx>

When the patch is applied, it takes the author name from the patch body. Even if
the server overwrites the from field from the header, it will be ignored.

Let me know if this works for you.
ta