Re: [PATCH v6 02/27] x86: Use symbol name in jump table for PIE support

From: Borislav Petkov
Date: Thu Feb 07 2019 - 12:11:56 EST


On Thu, Feb 07, 2019 at 09:04:45AM -0800, Thomas Garnier wrote:
> I assume that's an optimisation done by gcc later.

So why is that change even needed? Where does it break?

> The P modifier in the documentation does state that it is used to
> generate PIC code.

The documentation says:

"If used for a function, print the PLT suffix and generate PIC code. For
example, emit foo@PLT instead of âfooâ for the function foo()."

when you use %P for a function. Which is not how it is used here.

--
Regards/Gruss,
Boris.

Good mailing practices for 400: avoid top-posting and trim the reply.