Re: [PATCH 6/6] mm/gup: Documentation/vm/get_user_pages.rst, MAINTAINERS

From: John Hubbard
Date: Tue Feb 05 2019 - 16:53:58 EST


On 2/5/19 8:40 AM, Mike Rapoport wrote:
> Hi John,
>
> On Sun, Feb 03, 2019 at 09:21:35PM -0800, john.hubbard@xxxxxxxxx wrote:
>> From: John Hubbard <jhubbard@xxxxxxxxxx>
>>
>> 1. Added Documentation/vm/get_user_pages.rst
>>
>> 2. Added a GET_USER_PAGES entry in MAINTAINERS
>>
>> Cc: Dan Williams <dan.j.williams@xxxxxxxxx>
>> Cc: Jan Kara <jack@xxxxxxx>
>> Signed-off-by: JÃrÃme Glisse <jglisse@xxxxxxxxxx>
>> Signed-off-by: John Hubbard <jhubbard@xxxxxxxxxx>
>> ---
>> Documentation/vm/get_user_pages.rst | 197 ++++++++++++++++++++++++++++
>> Documentation/vm/index.rst | 1 +
>> MAINTAINERS | 10 ++
>> 3 files changed, 208 insertions(+)
>> create mode 100644 Documentation/vm/get_user_pages.rst
>>
>> diff --git a/Documentation/vm/get_user_pages.rst b/Documentation/vm/get_user_pages.rst
>> new file mode 100644
>> index 000000000000..8598f20afb09
>> --- /dev/null
>> +++ b/Documentation/vm/get_user_pages.rst
>
> It's great to see docs coming alone with the patches! :)
>
> Yet, I'm a bit confused. The documentation here mostly describes the
> existing problems that this patchset aims to solve, but the text here does
> not describe the proposed solution.
>

Yes, that's true. I'll take another pass at it with that in mind.

thanks,
--
John Hubbard
NVIDIA