Re: linux-next: Tree for Feb 5 (btrfs/zstd)

From: David Sterba
Date: Tue Feb 05 2019 - 13:26:26 EST


On Tue, Feb 05, 2019 at 09:40:40AM -0800, Randy Dunlap wrote:
> On 2/4/19 10:12 PM, Stephen Rothwell wrote:
> > Hi all,
> >
> > Changes since 20190204:
> >
>
> on i386:
>
> ../fs/btrfs/zstd.c: In function âzstd_reclaim_timer_fnâ:
> ../fs/btrfs/zstd.c:27:35: warning: integer overflow in expression [-Woverflow]
> #define ZSTD_BTRFS_RECLAIM_NS (45 * NSEC_PER_SEC)
> ^
> ../fs/btrfs/zstd.c:96:33: note: in expansion of macro âZSTD_BTRFS_RECLAIM_NSâ
> if (now < victim->last_used + ZSTD_BTRFS_RECLAIM_NS)

Thanks for the report. There's a v2 of the patchset that uses the
timer_after helper and this warning should be gone. The updated version
will appear in for-next soonish.