Re: [PATCH] platform/x86: intel_int0002_vgpio: Implement irq_set_wake

[Hans de Goede]

Hi,

On 2/2/19 8:04 PM, Maxim Mikityanskiy wrote:
> On Sat, Feb 2, 2019 at 12:52 AM Hans de Goede <hdegoede@xxxxxxxxxx> wrote:
> > Hi,
> >
> > On 1/31/19 8:47 PM, Maxim Mikityanskiy wrote:
> > > Hi,
> > >
> > > On Mon, Sep 24, 2018 at 5:37 PM Hans de Goede <hdegoede@xxxxxxxxxx> wrote:
> > > > We were relying on the interrupt being shared with the ACPI SCI and the
> > > > ACPI core calling irq_set_wake. But that does not always happen on
> > > > Bay Trail devices, so we should do it ourselves.
> > > >
> > > > This fixes wake from USB not working on various Bay Trail devices.
> > >
> > > This patch breaks suspend on ASUS E202SA (bisecting pointed me to this
> > > patch, and if I revert it and build 4.20.5 without this patch,
> > > everything works flawlessly).
> >
> > Thank you for the bug report, can you please test 4.20.5 with the attached
> > patch on top? That should fix it. Once I've confirmation that this fixes
> > things I will submit the patch upstream.
>
> I've tested your patch against both 4.20.5 and 4.20.6, and it works
> fine. Thank you for such a quick fix.

Thank you for the bug-report and for testing the fix. I've submitted
the patch upstream now, so hopefully it will show up in a 4.20.x
release soon.

Regards,

Hans