Re: [PATCH 1/4] arm64: dump: no need to check return value of debugfs_create functions

From: Greg Kroah-Hartman
Date: Wed Jan 30 2019 - 14:33:53 EST


On Wed, Jan 30, 2019 at 06:21:02PM +0000, Will Deacon wrote:
> Hi Greg,
>
> On Tue, Jan 22, 2019 at 03:41:11PM +0100, Greg Kroah-Hartman wrote:
> > When calling debugfs functions, there is no need to ever check the
> > return value. The function can work or not, but the code logic should
> > never do something different based on this.
> >
> > Cc: Catalin Marinas <catalin.marinas@xxxxxxx>
> > Cc: Will Deacon <will.deacon@xxxxxxx>
> > Cc: Marc Zyngier <marc.zyngier@xxxxxxx>
> > Cc: Peng Donglin <dolinux.peng@xxxxxxxxx>
> > Cc: <linux-arm-kernel@xxxxxxxxxxxxxxxxxxx>
> > Signed-off-by: Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx>
> > ---
> > arch/arm64/include/asm/ptdump.h | 9 +++------
> > arch/arm64/mm/dump.c | 4 ++--
> > arch/arm64/mm/ptdump_debugfs.c | 7 ++-----
> > 3 files changed, 7 insertions(+), 13 deletions(-)
>
> Are you taking this via your tree, or would you like us to queue it in
> arm64?

What ever is easiest for you is fine with me, I can handle it either
way, just let me know.

thanks,

greg k-h