Re: linux-next: Fixes tag needs some work in the input-current tree

From: Dmitry Torokhov
Date: Fri Jan 25 2019 - 18:59:18 EST


On Fri, Jan 25, 2019 at 3:56 PM Dmitry Torokhov
<dmitry.torokhov@xxxxxxxxx> wrote:
>
> Hi Stephen,
>
> On Thu, Jan 24, 2019 at 3:09 AM Stephen Rothwell <sfr@xxxxxxxxxxxxxxxx> wrote:
> >
> > Hi Dmitry,
> >
> > In commit
> >
> > ec87da107d11 ("Input: olpc_apsp - assign priv->dev earlier")
> >
> > Fixes tag
> >
> > Fixes: commit af518342effd ("Input: olpc_apsp - check FIFO status on open(), not probe()")
> >
> > has these problem(s):
> >
> > - No SHA1 recognised
> >
> > The "commit" at the start of the tag value was unexpected.
>
> Hmm, this is really weird:
>
> dtor@dtor-ws:~/kernel/master (for-linus)$ git log --oneline --
> drivers/input/serio/olpc_apsp.c
> ec87da107d11 Input: olpc_apsp - assign priv->dev earlier
> 2a58dd767bf9 Input: olpc_apsp - remove set but not used variable 'np'
> ed22cee91a88 Input: olpc_apsp - enable the SP clock
> af518342effd Input: olpc_apsp - check FIFO status on open(), not probe()
>
> As you can see there is that SHA1 in question present in my for-linus branch.

Argh, I see what you mean, the word "commit" should be omitted. Oh
well, it's in the branch that I loath to rebase, so it will have to
stay as is.

--
Dmitry