Re: [PATCH v3 13/23] drm/qxl: use shadow bo directly

From: Noralf TrÃnnes
Date: Fri Jan 25 2019 - 11:59:23 EST




Den 18.01.2019 13.20, skrev Gerd Hoffmann:
> Pass the shadow bo to qxl_io_create_primary() instead of expecting
> qxl_io_create_primary to check bo->shadow. Set is_primary flag on the
> shadow bo. Move the is_primary tracking into qxl_io_create_primary()
> and qxl_io_destroy_primary() functions.
>
> That simplifies primary surface tracking and the workflow in
> qxl_primary_atomic_update().
>
> Signed-off-by: Gerd Hoffmann <kraxel@xxxxxxxxxx>
>
> qxl_io_create/destroy_primary: primary_bo tracking [fixup]
> ---

I'm unable to follow the logic, but I didn't spot anything suspicious
looking.

Acked-by: Noralf TrÃnnes <noralf@xxxxxxxxxxx>