Re: [PATCH -next] watchdog: pika_wdt: drop pointless static qualifier in pikawdt_init

[Guenter Roeck]

On Wed, Jan 23, 2019 at 05:05:24PM +0800, YueHaibing wrote:
> There is no need to have the 'post1' variable static since
> new value always be assigned before use it.
> 
> Signed-off-by: YueHaibing <yuehaibing@xxxxxxxxxx>

Reviewed-by: Guenter Roeck <linux@xxxxxxxxxxxx>

Is anyone still using this driver ? If yes it might make sense to convert
it to use the watchdog subsystem.

Guenter

> ---
>  drivers/watchdog/pika_wdt.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/watchdog/pika_wdt.c b/drivers/watchdog/pika_wdt.c
> index e0a6f8c..bb97f5b 100644
> --- a/drivers/watchdog/pika_wdt.c
> +++ b/drivers/watchdog/pika_wdt.c
> @@ -225,7 +225,7 @@ static int __init pikawdt_init(void)
>  {
>  	struct device_node *np;
>  	void __iomem *fpga;
> -	static u32 post1;
> +	u32 post1;
>  	int ret;
>  
>  	np = of_find_compatible_node(NULL, NULL, "pika,fpga");
> -- 
> 2.7.0
> 
>