Re: New warnings with gcc9

[Miguel Ojeda]

Hi Laura,

On Wed, Jan 23, 2019 at 4:27 PM Laura Abbott <labbott@xxxxxxxxxx> wrote:
>
> There's also some missing attribute warnings. The majority are caused by a
> missing attribute in module_init/module_exit
>
> BUILDSTDERR: In file included from drivers/scsi/hptiop.c:18:
> BUILDSTDERR: ./include/linux/module.h:132:6: warning: 'init_module' specifies less restrictive attribute than its target 'hptiop_module_init': 'cold' [-Wmissing-attributes]
> BUILDSTDERR:   132 |  int init_module(void) __attribute__((alias(#initfn)));
> BUILDSTDERR:       |      ^~~~~~~~~~~
> BUILDSTDERR: drivers/scsi/hptiop.c:1704:1: note: in expansion of macro 'module_init'
> BUILDSTDERR:  1704 | module_init(hptiop_module_init);
> BUILDSTDERR:       | ^~~~~~~~~~~
> BUILDSTDERR: drivers/scsi/hptiop.c:1692:19: note: 'init_module' target declared here
> BUILDSTDERR:  1692 | static int __init hptiop_module_init(void)
> BUILDSTDERR:       |

I have been discussing these new -Wmissing-attributes warnings with
the author, Martin Sebor. There is a new copy() attribute that we may
take advantage of, but I will send the patch I have since you already
found this :-)

Cheers,
Miguel