Re: linux-next: Fixes tags need some work in the dma-mapping-fixes tree

From: Christoph Hellwig
Date: Wed Jan 23 2019 - 02:19:37 EST


On Wed, Jan 23, 2019 at 07:47:47AM +1100, Stephen Rothwell wrote:
> Hi Christoph,
>
> In commit
>
> 702e8ed37bed ("arm64/xen: fix xen-swiotlb cache flushing")
>
> Fixes tag
>
> Fixes: 356da6d0cd ("dma-mapping: bypass indirect calls for dma-direct")
>
> has these problem(s):
>
> - SHA1 should be at least 12 digits long

When did we decide on that? As far as I know it was bumped to 10
a while ago. 12 basically makes the line even more unreadable.

> In commit
>
> 8218a55b6b91 ("sbitmap: Protect swap_lock from hardirq")
>
> Fixes tag
>
> Fixes: ab53dcfb3e7b ("sbitmap: Protect swap_lock from hardirq")
>
> has these problem(s):
>
> - Target SHA1 does not exist
>
> This later patch appears to already be in Linus' tree as commit
> fe76fc6aaf53 (also with an incorrect Fixes tag :-()

That commit is not from the dma-mapping tree..