Re: [PATCHv3 1/4] arm64: dts: qcom: sdm845: Add Coresight support

From: Sai Prakash Ranjan
Date: Tue Jan 22 2019 - 08:41:49 EST


Hi Mathieu,

On 1/22/2019 12:07 AM, Mathieu Poirier wrote:
Hi Sai,

On Fri, Jan 18, 2019 at 05:52:53PM +0530, Sai Prakash Ranjan wrote:
Add coresight components found on Qualcomm SDM845 SoC.

Signed-off-by: Sai Prakash Ranjan <saiprakash.ranjan@xxxxxxxxxxxxxx>

---
This depends on AMBA bus pclk change by Bjorn Andersson [1].
Also depends on patch ("arm64: dts: qcom: sdm845: Increase address
and size cells for soc") [2].

[1] https://lore.kernel.org/lkml/20190106080915.4493-7-bjorn.andersson@xxxxxxxxxx/
[2] https://lore.kernel.org/lkml/20190117042940.25487-2-bjorn.andersson@xxxxxxxxxx/

Thank you for making modifications to this patch - I am happy with how it stands
now. I tried to compile it on my side on a 5.0-rc3 kernel and even after
applying the above two patches you pointed out I get the following error:

Error: /home/mpoirier/work/coresight/kernel-maint/arch/arm64/boot/dts/qcom/sdm845.dtsi:1356.31-32 syntax error
FATAL ERROR: Unable to parse input tree

From what I see neither aoss_qmp or AOSS_QMP_QDSS_CLK are defined. Are there
more patches that need to be applied?


Sorry, I added all the dependent patches in the cover letter, but
forgot to add the main dependent patch here, now added in v4.

Thanks,
Sai

--
QUALCOMM INDIA, on behalf of Qualcomm Innovation Center, Inc. is a member
of Code Aurora Forum, hosted by The Linux Foundation