Re: [PATCH] perf scripts python: Add Python 3 support to mem-phys-addr.py

From: Tony Jones
Date: Mon Jan 21 2019 - 18:46:10 EST


On 1/17/19 1:48 AM, seeteena wrote:
> I have added

>> You have not added "from __future__ import print_function", so you're
>> relying on a Python 2 parsing oddity to make this work.

I didn't see Jon's comment earlier. Sorry to have given conflicting advice. I'd not considered it a parsing oddity but I think he's correct.

There is a flip side however and that is that this oddity probably works in versions older than v2.6 which is as far back as future support exists.

I can't imagine anyone is using < 2.6 but I have no idea what PYTHON=python2 actually implies. The other option is to switch to sys.write.stdout
which has always had more consistent semantics.

Tony