Re: [PATCH v4 4/4] hwrng: add OP-TEE based rng driver

[Sumit Garg]

On Mon, 21 Jan 2019 at 16:16, Greg KH <gregkh@xxxxxxxxxxxxxxxxxxx> wrote:
>
> On Mon, Jan 21, 2019 at 11:43:14AM +0100, Ard Biesheuvel wrote:
> > On Mon, 21 Jan 2019 at 11:30, Greg KH <gregkh@xxxxxxxxxxxxxxxxxxx> wrote:
> > >
> > > On Mon, Jan 21, 2019 at 02:59:19PM +0530, Sumit Garg wrote:
> > > > --- /dev/null
> > > > +++ b/drivers/char/hw_random/optee-rng.c
> > > > @@ -0,0 +1,272 @@
> > > > +// SPDX-License-Identifier: GPL-2.0
> > >
> > > Nice, but:
> > >
> > > <snip>
> > >
> > > > +MODULE_LICENSE("GPL");
> > >
> > > This string means "GPL2+", you need "GPLv2" here instead.
> > >
> >
> > I think you need a space there: "GPL v2" or it doesn't get picked up
> > correctly (or at least, it didn't use to)
>
> Sorry, yes, see I even got it wrong :)
>
> The correct strings are in include/linux/module.h
>

Ok will correct license as:

+MODULE_LICENSE("GPL v2");

-Sumit