Re: [PATCH] m68k: Avoid VLA use in mangle_kernel_stack()

From: Geert Uytterhoeven
Date: Mon Jan 21 2019 - 04:41:51 EST


On Mon, Jan 7, 2019 at 10:29 AM Geert Uytterhoeven <geert@xxxxxxxxxxxxxx> wrote:
> With gcc 7.3.0:
>
> arch/m68k/kernel/signal.c: In function âmangle_kernel_stackâ:
> arch/m68k/kernel/signal.c:654:3: warning: ISO C90 forbids variable length array âbufâ [-Wvla]
> unsigned long buf[fsize / 2]; /* yes, twice as much */
> ^~~~~~~~
>
> Replace the variable size by the upper limit, which is 168 bytes.
>
> Signed-off-by: Geert Uytterhoeven <geert@xxxxxxxxxxxxxx>

Thanks, applied and queued for v5.1.

Gr{oetje,eeting}s,

Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds