Re: [RFC] Provide in-kernel headers for making it easy to extend the kernel

From: Greg KH
Date: Sat Jan 19 2019 - 03:25:39 EST


On Fri, Jan 18, 2019 at 05:55:43PM -0500, Joel Fernandes wrote:
> --- /dev/null
> +++ b/kernel/kheaders.c
> @@ -0,0 +1,74 @@
> +// SPDX-License-Identifier: GPL-2.0

Nice, but:

<snip>

> +MODULE_LICENSE("GPL");

That means "GPL2+" (yeah, horrible, I know, we all get it wrong, look at
include/linux/module.h for details)

So you should change that line to:
MODULE_LICENSE("GPLv2");

Other than that, nice work.

greg k-h