Re: [PATCH 4/5] riscv: treat cpu devicetree nodes without status as enabled

From: Paul Walmsley
Date: Fri Jan 18 2019 - 20:50:41 EST


On Fri, 18 Jan 2019, Johan Hovold wrote:

> Follow the Linux convention and treat devicetree nodes without a status
> property as enabled rather than disabled, while also allowing "ok" as a
> shorthand for "okay".
>
> Signed-off-by: Johan Hovold <johan@xxxxxxxxxx>

Reviewed-by: Paul Walmsley <paul.walmsley@xxxxxxxxxx>

... although I probably would have phrased the commit message slightly
differently - something like "Use of_device_is_available() in
riscv_of_processor_hartid(), in place of an open-coded test." That frames
the change as one that removes custom code in place of an existing
standard function for the same purpose.


- Paul