Re: [PATCH 1/1] irqchip: gpcv2: make config option visible

[Marc Zyngier]

On 18/01/2019 09:49, Aisheng Dong wrote:
>> From: Marc Zyngier [mailto:marc.zyngier@xxxxxxx]
>> Sent: Friday, January 18, 2019 5:13 PM
>> On 18/01/2019 07:41, Aisheng Dong wrote:
>>> Make GPCv2 config option visible, then user can select it in defconfig
>>> for ARMv8 platforms.
>>>
>>> Cc: Thomas Gleixner <tglx@xxxxxxxxxxxxx>
>>> Cc: Jason Cooper <jason@xxxxxxxxxxxxxx>
>>> Cc: Marc Zyngier <marc.zyngier@xxxxxxx>
>>> Cc: Shawn Guo <shawnguo@xxxxxxxxxx>
>>> Cc: Lucas Stach <l.stach@xxxxxxxxxxxxxx>
>>> Cc: Andrey Smirnov <andrew.smirnov@xxxxxxxxx>
>>> Signed-off-by: Dong Aisheng <aisheng.dong@xxxxxxx>
>>> ---
>>>  drivers/irqchip/Kconfig | 3 ++-
>>>  1 file changed, 2 insertions(+), 1 deletion(-)
>>>
>>> diff --git a/drivers/irqchip/Kconfig b/drivers/irqchip/Kconfig index
>>> 3d1e607..ed04d47 100644
>>> --- a/drivers/irqchip/Kconfig
>>> +++ b/drivers/irqchip/Kconfig
>>> @@ -289,7 +289,8 @@ config RENESAS_H8S_INTC
>>>  	select IRQ_DOMAIN
>>>
>>>  config IMX_GPCV2
>>> -	bool
>>> +	bool "i.MX GPCv2 IRQ chip"
>>> +	depends on ARCH_MXC || (COMPILE_TEST && OF)
>>>  	select IRQ_DOMAIN
>>>  	help
>>>  	  Enables the wakeup IRQs for IMX platforms with GPCv2 block
>>>
>>
>> How does it help exactly? It is pretty difficult for a user to know exactly what
>> they need. I'd rather see it selected by ARCH_MXC, which makes it
> 
> ARM64 SoC maintainers suggest not add more driver specific options except an
> Generic ARCH option.
> 
> As GPCv2 is also used in MX8MQ. So we may select it in armv8 defconfig.
> If this option is invisible, we can't select it.

And conversely, users have no idea of what letter soup they have to
select to make their HW work properly. Selecting the driver when the
platform is supposed to be supported is the right way to solve this problem.

Thanks,

	M.
-- 
Jazz is not dead. It just smells funny...