Re: [PATCH v4 0/5] drm/bridge: various small lvds-encoder things

[Andrzej Hajda]

On 11.01.2019 16:18, Peter Rosin wrote:
> Hi!
>
> I'm not sure if I should have added the texas chips to the lvds_encoder_match
> list in the driver, right next to the thine,thc63lvdm83d entry, but ended
> up not doing that. That can always be added later, if needed...
>
> Changes since v3:
> - retained a (modified) note in lvds-transmitter.txt about encoders with
>   additional device-specific properties
> - added tag from Rob on patch 3/5
>
> Changes since v2:
> - changed from pwdn-gpios to powerdown-gpios after discussion with Rob with
>   new patch 3/5 updating the thine,thc63lvdm83d binding as well as a
>   consequence
> - added patch 4/5 which helps keep lines shorter in the lvds-encoder driver
> - added tag from Rob on patch 2/5
>
> Changes since v1:
> - fork out the bindings for the texas chips into their own file in order
>   to avoid clutter in the generic lvds-transmitter binding.
> - added a patch to remove some surplus stuff in the generic lvds-transmitter
>   binding.
>
> Cheers,
> Peter


Queued to drm-misc-next.


One thing I have spotted after merging is that there no need to
null-check before gpiod_set_value_cansleep, no big deal, I guess.


Regards

Andrzej


>
> Peter Rosin (5):
>   dt-bindings: display: bridge: fork out ti,ds90c185 from
>     lvds-transmitter
>   dt-bindings: display: bridge: lvds-transmitter: cleanup example
>   dt-bindings: display: bridge: thc63lvdm83d: use standard
>     powerdown-gpios
>   drm/bridge: lvds-encoder: add dev helper variable in .probe()
>   drm/bridge: lvds-encoder: add powerdown-gpios support
>
>  .../bindings/display/bridge/lvds-transmitter.txt   | 12 ++---
>  .../bindings/display/bridge/thine,thc63lvdm83d.txt |  2 +-
>  .../bindings/display/bridge/ti,ds90c185.txt        | 55 ++++++++++++++++++++++
>  drivers/gpu/drm/bridge/lvds-encoder.c              | 53 +++++++++++++++++----
>  4 files changed, 103 insertions(+), 19 deletions(-)
>  create mode 100644 Documentation/devicetree/bindings/display/bridge/ti,ds90c185.txt
>