Re: [PATCH v2 8/8] RISC-V: Assign hwcap only according to current cpu.

From: Atish Patra
Date: Thu Jan 17 2019 - 21:14:00 EST


On 1/15/19 5:56 AM, Christoph Hellwig wrote:
On Tue, Jan 08, 2019 at 01:38:38AM -0800, Atish Patra wrote:
Currently, we set hwcap based on first valid cpu from
DT. This may not be correct always as that CPU might not
be current booting cpu.

Set hwcap based on the current cpu instead of first
valid CPU from DT.

This is generally the right thing to do. But can the kernel even cope
with different hwcaps per hart?

I don't think so.
I know arm land and I think x86 as well
don't, so we might want to add a sanity check that they match or reduce
them to the common subset.


I will add a sanity check that they match and throw a warning if they don't.

Regards,
Atish