Re: [PATCH] rtlwifi: rtl818x: fix indentation issue

[Larry Finger]

On 1/17/19 1:29 PM, Joe Perches wrote:
> On Thu, 2019-01-17 at 15:28 +0000, Colin King wrote:
> > From: Colin Ian King <colin.king@xxxxxxxxxxxxx>
> >
> > There is a statement that is indented too deeply. Fix this.
>
> Thanks.
>
> > diff --git a/drivers/net/wireless/realtek/rtl818x/rtl8180/dev.c b/drivers/net/wireless/realtek/rtl818x/rtl8180/dev.c
> []
> > @@ -803,7 +803,7 @@ static void rtl8180_config_cardbus(struct ieee80211_hw *dev)
> >   		rtl818x_iowrite16(priv, FEMR_SE, 0xffff);
> >   	} else {
> >   		reg16 = rtl818x_ioread16(priv, &priv->map->FEMR);
> > -			reg16 |= (1 << 15) | (1 << 14) | (1 << 4);
> > +		reg16 |= (1 << 15) | (1 << 14) | (1 << 4);
> >   		rtl818x_iowrite16(priv, &priv->map->FEMR, reg16);
> >   	}
>
> trivia:
>
> It sure looks as if there could be some rather useful
> conversions of magic bits to constants one day.

How much work is warranted for this driver for a device that is not likely in 
use anywhere in the wild? In addition, I'm not sure anyone knows what those bits 
actually do, I certainly do not have a product sheet for that one.

Larry