Re: [PATCH 2/3] PCI: hv: Add vPCI version protocol negotiation

From: Bjorn Helgaas
Date: Thu Jan 17 2019 - 09:59:42 EST


On Fri, Jan 18, 2019 at 02:17:17AM +0530, Ajay Kaher wrote:
> Hyper-V vPCI offers different protocol versions. Add the infra for
> negotiating the one to use.
>
> Signed-off-by: Jork Loeser <jloeser@xxxxxxxxxxxxx>
> Signed-off-by: Bjorn Helgaas <bhelgaas@xxxxxxxxxx>

I did not sign off on this, please remove.

> Reviewed-by: K. Y. Srinivasan <kys@xxxxxxxxxxxxx>
> Acked-by: K. Y. Srinivasan <kys@xxxxxxxxxxxxx>
> Signed-off-by: Ajay Kaher <akaher@xxxxxxxxxx>
> ---
> drivers/pci/host/pci-hyperv.c | 72 +++++++++++++++++++++++++++++++------------
> 1 file changed, 53 insertions(+), 19 deletions(-)
>
> diff --git a/drivers/pci/host/pci-hyperv.c b/drivers/pci/host/pci-hyperv.c
> index 9e44adf..6eed85b 100644
> --- a/drivers/pci/host/pci-hyperv.c
> +++ b/drivers/pci/host/pci-hyperv.c
> @@ -65,22 +65,37 @@
> * major version.
> */
>
> -#define PCI_MAKE_VERSION(major, minor) ((u32)(((major) << 16) | (major)))
> +#define PCI_MAKE_VERSION(major, minor) ((u32)(((major) << 16) | (minor)))

This looks like a bug fix that should be in its own patch.